Skip to content

WS-1576: Remove script service params from psammead components #13295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 76 commits into
base: latest
Choose a base branch
from
Draft

WS-1576: Remove script service params from psammead components #13295

wants to merge 76 commits into from
+1,709 −13,063

Conversation

@karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Oct 19, 2025 •
edited by elvinasv
Loading

Resolves JIRA: https://bbc.atlassian.net/browse/WS-1576

Summary

A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.

Code changes

  • A bullet point list of key code changes that have been made.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

elvinasv and others added 30 commits June 30, 2025 16:02
@elvinasv
refactor: getSansRegular, getSansBold, getSerifMedium to theme fontVa…
55af5d4 
…riants
@elvinasv
refactor: remaining psammead font variant migration
581cfb2
@elvinasv
refactor: font size migrations
c26b531
@elvinasv
Merge branch 'latest' into WS-550-use-theme-font-variants-for-legacy-…
19a3284 
…psammead-components
@karinathomasbbc
Merge branch 'latest' of github.com:bbc/simorgh into WS-550-use-theme…
0d8a198 
…-font-variants-for-legacy-psammead-components
@karinathomasbbc
Typography & font cleanup
bbeca36
@karinathomasbbc
Remove references of script & service as parameters if no longer requ…
8a5ea2f 
…ired for styling
@karinathomasbbc
Fix tests
4c25e72
@karinathomasbbc
Remove references of script & service as parameters if no longer requ…
2242e55 
…ired for styling
@karinathomasbbc
Remove unused imports
e33e967
@karinathomasbbc
Merge branch 'latest' of github.com:bbc/simorgh into WS-550-use-theme…
637cee9 
…-font-variants-for-legacy-psammead-components
@karinathomasbbc
Revert "Remove references of script & service as parameters if no lon…
6b2893b 
…ger required for styling"

This reverts commit 2242e55.
@karinathomasbbc
Remove references to script
ad38bd2
@karinathomasbbc
Further cleanup
b7d21ac
@karinathomasbbc
Further cleanup of imported scripts
2d49e5c
@karinathomasbbc
Fix test
ebd34c3
@karinathomasbbc
Revert refactor
598efbd
@karinathomasbbc
Move fontWeight to above fontStyle to determine how many snapshot tes…
13fef24 
…ts fail
@karinathomasbbc
Bump bundle size
df304c3
@karinathomasbbc
Bump bundle size
a03fdc4
@karinathomasbbc
Reorder snapshots
583aa4d
@karinathomasbbc
Update all snapshots
2b47687
@karinathomasbbc
Merge branch 'test-failing-snaps-font-weight-order' into WS-550-use-t…
8f55709 
…heme-font-variants-for-legacy-psammead-components
@karinathomasbbc
Update snaps
7a8e10a
@karinathomasbbc
Reinstate psammead-bulletin
0f9f684
@karinathomasbbc
Reinstate correct snapshots
430d188
@karinathomasbbc
Merge branch 'test-failing-snaps-font-weight-order' into WS-550-use-t…
f58cc28 
…heme-font-variants-for-legacy-psammead-components
@karinathomasbbc
More updated snaps
a3579da
@karinathomasbbc
Update NextJS snapshots
ec13dda
@karinathomasbbc
Merge branch 'test-failing-snaps-font-weight-order' into WS-550-use-t…
38fb89d 
…heme-font-variants-for-legacy-psammead-components
karinathomasbbc and others added 17 commits October 19, 2025 14:54
@karinathomasbbc
Pass service as a parameter to the render function to ensure that i…
7c1c2d7 
…t's using the correct theme provider
@karinathomasbbc
Pass service as a parameter to the render function to ensure that i…
56647c8 
…t's using the correct theme provider
@karinathomasbbc
Pass service as a parameter to the render function to ensure that i…
7a152b8 
…t's using the correct theme provider
@karinathomasbbc
Merge branch 'test-failing-snaps-font-weight-order' of github.com:bbc…
3c6071b 
…/simorgh into WS-550-use-theme-font-variants-for-legacy-psammead-components
@karinathomasbbc
Pass service as a parameter to the render function to ensure that i…
2d047ef 
…t's using the correct theme provider
@karinathomasbbc
Update snapshots again
0de8de9
@karinathomasbbc
Fix tests
db9438b
@karinathomasbbc
Merge branch 'latest' of github.com:bbc/simorgh into WS-550-use-theme…
57c8746 
…-font-variants-for-legacy-psammead-components
@karinathomasbbc
Revert "Move fontWeight to above fontStyle to determine how many snap…
1f8871e 
…shot tests fail"

This reverts commit 13fef24.
@karinathomasbbc
Update snapshots
4de4e6b
@karinathomasbbc
Fix test & update snapshot
b3f64fd
@karinathomasbbc
Merge branch 'test-failing-snaps-font-weight-order' of github.com:bbc…
5761b41 
…/simorgh into WS-550-use-theme-font-variants-for-legacy-psammead-components
@karinathomasbbc
Fix tests & update snapshots
b4fa5a9
@karinathomasbbc
Remove extra ;
dccc011
@karinathomasbbc
Delete unused imports
90cb6c1
@karinathomasbbc
Merge branch 'test-failing-snaps-font-weight-order' into WS-550-use-t…
6914bad 
…heme-font-variants-for-legacy-psammead-components
@karinathomasbbc
Update snapshots
757cb7e
@karinathomasbbc
Merge branch 'WS-550-use-theme-font-variants-for-legacy-psammead-comp…
fabe31a 
…onents' of github.com:bbc/simorgh into remove-script-service-params-from-psammead-components
@karinathomasbbc
Add test case for dari
e4a2e55
@karinathomasbbc
Update snaps
647e05e
@karinathomasbbc
Update snaps
f71949a
@karinathomasbbc
Merge branch 'latest' of github.com:bbc/simorgh into WS-550-use-theme…
c8a93b5 
…-font-variants-for-legacy-psammead-components
@karinathomasbbc
Merge branch 'WS-550-use-theme-font-variants-for-legacy-psammead-comp…
3b7905f 
…onents' of github.com:bbc/simorgh into remove-script-service-params-from-psammead-components
@karinathomasbbc
Update snaps
0800c96
@karinathomasbbc
Fix test
6b8f645
@karinathomasbbc
Adjust bundle size
0980c93
Base automatically changed from WS-550-use-theme-font-variants-for-legacy-psammead-components to latest November 26, 2025 11:39
@elvinasv elvinasv changed the title Remove script service params from psammead components WS-1576: Remove script service params from psammead components Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@elvinasv elvinasv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karinathomasbbc @elvinasv